On Fri, Dec 11, 2020 at 01:19:15AM +0000, Andre Przywara wrote: > A new SoC, a new compatible string. > Also we were too miserly with just allowing seven interrupt banks. > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com> > --- > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > index 5240487dfe50..292b05d9ed08 100644 > --- > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > +++ > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > @@ -53,6 +53,8 @@ properties: > - allwinner,sun50i-h5-pinctrl > - allwinner,sun50i-h6-pinctrl > - allwinner,sun50i-h6-r-pinctrl > + - allwinner,sun50i-h616-pinctrl > + - allwinner,sun50i-h616-r-pinctrl > - allwinner,suniv-f1c100s-pinctrl > - nextthing,gr8-pinctrl > > @@ -61,7 +63,7 @@ properties: > > interrupts: > minItems: 1 > - maxItems: 7 > + maxItems: 8 > description: > One interrupt per external interrupt bank supported on the > controller, sorted by bank number ascending order. > @@ -91,7 +93,7 @@ properties: > bank found in the controller > $ref: /schemas/types.yaml#/definitions/uint32-array > minItems: 1 > - maxItems: 5 > + maxItems: 8 > > patternProperties: > # It's pretty scary, but the basic idea is that: > @@ -145,6 +147,18 @@ allOf: > # boards are defining it at the moment so it would generate a lot of > # warnings. > > + - if: > + properties: > + compatible: > + enum: > + - allwinner,sun50i-h616-pinctrl > + > + then: > + properties: > + interrupts: > + minItems: 8 > + maxItems: 8 > +
You don't need to have both if they are equals, and in this particular case we already check that the maximum is 8 so there's no need to repeat that check here. Maxime
signature.asc
Description: PGP signature
