Hi,
On 12/14/20 8:29 PM, Mario Limonciello wrote:
> commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME
> systems")
> disabled s0ix flows for systems that have various incarnations of the
> i219-LM ethernet controller. This was done because of some regressions
> caused by an earlier
> commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable connected case")
> with i219-LM controller.
>
> Per discussion with Intel architecture team this direction should be changed
> and
> allow S0ix flows to be used by default. This patch series includes
> directional
> changes for their conclusions in https://lkml.org/lkml/2020/12/13/15.
>
> Changes from v4 to v5:
> - If setting S0ix to enabled in ethtool examine the hardware generation.
> If running on hardware older than Cannon Point return an error.
> - Increase ULP timeout to 2.5 seconds, but show a warning after 1 second.
Thank you. I've given v5 a test on a Lenovo X1 Carbon 8th gen (AMT capable)
and things work fine there with v5:
Tested-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
> Changes from v3 to v4:
> - Drop patch 1 for proper s0i3.2 entry, it was separated and is now merged
> in kernel
> - Add patch to only run S0ix flows if shutdown succeeded which was suggested
> in
> thread
> - Adjust series for guidance from https://lkml.org/lkml/2020/12/13/15
> * Revert i219-LM disallow-list.
> * Drop all patches for systems tested by Dell in an allow list
> * Increase ULP timeout to 1000ms
> Changes from v2 to v3:
> - Correct some grammar and spelling issues caught by Bjorn H.
> * s/s0ix/S0ix/ in all commit messages
> * Fix a typo in commit message
> * Fix capitalization of proper nouns
> - Add more pre-release systems that pass
> - Re-order the series to add systems only at the end of the series
> - Add Fixes tag to a patch in series.
>
> Changes from v1 to v2:
> - Directly incorporate Vitaly's dependency patch in the series
> - Split out s0ix code into it's own file
> - Adjust from DMI matching to PCI subsystem vendor ID/device matching
> - Remove module parameter and sysfs, use ethtool flag instead.
> - Export s0ix flag to ethtool private flags
> - Include more people and lists directly in this submission chain.
>
>
> Mario Limonciello (4):
> e1000e: Only run S0ix flows if shutdown succeeded
> e1000e: bump up timeout to wait when ME un-configures ULP mode
> Revert "e1000e: disable s0ix entry and exit flows for ME systems"
> e1000e: Export S0ix flags to ethtool
>
> drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
> drivers/net/ethernet/intel/e1000e/ethtool.c | 46 ++++++++++++++++
> drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 ++++--
> drivers/net/ethernet/intel/e1000e/netdev.c | 59 ++++-----------------
> 4 files changed, 70 insertions(+), 52 deletions(-)
>
> --
> 2.25.1
>
