Em Tue, Dec 15, 2020 at 04:24:20PM +0100, Jiri Olsa escreveu: > On Tue, Dec 15, 2020 at 12:14:13PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Dec 10, 2020 at 09:43:29PM +0100, Jiri Olsa escreveu: > > > Adding new control events to enable/disable specific event. > > > The interface string for control file are: > > > > > > 'enable-<EVENT NAME>' > > > 'disable-<EVENT NAME>' > > > > Wwy do we have "enable-" as the "tag" for this? > > the whole 'enable-' is prefix for command that enables specific event > following '-' starts the event name > > > > > Also is it possible to use "enable sched:*" and have that match what is > > in the evlist and enable (or disable, if using "disable sched:*") what > > matches? > > yep, that should be possible to add > > > > > This second suggestion can be done on top of this, i.e. as an > > enhancement, but mixing up the command (enable, disable) with its > > arguments looks strange. > > the '-' determines that there's event name following, > pure 'enable' switches on everything
I see it, but why not use the more natural ' ' space to separate the command from its arguments? Just like in a bash command line, say? I.e. why not: enable to enable everything, and: enable sched:sched_switch To enable just the "sched:sched_switch" event? - Arnaldo
