On Dec 17, 2007 3:17 PM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > Tony Luck wrote: > >> + static char target[80]; > > ... > >> + sprintf(target, > >> "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-" > >> + "%02x%02x%02x%02x%02x%02x", > > > > [80] is overkill ... [37] bytes should be enough (unless I went > > cross-eyed counting the "%02x" :-) > > > > %02x doesn't guarantee that it's at most 2, but at LEAST 2...
How will you fit a number that requires >2 hex digits into an "unsigned char"? Alternatively ... if %02x may spew more that 2 characters, can you be sure that [80] is enough? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
