Em Thu, Dec 24, 2020 at 08:24:06PM +0800, Tian Tao escreveu:
> since commit c93e4aeed1be
> ("Makefile.extrawarn: remove -Wnested-externs warning")
> has removed this check, so it's not needed here.But the above commit is for the kernel, scripts/Makefile.extrawarn isn't included in tools/perf/ This is the one used: [acme@five perf]$ grep nested-externs tools/scripts/Makefile.include EXTRA_WARNINGS += -Wnested-externs [acme@five perf]$ But since you're looking at this, you could consider adding tools/scripts/Makefile.extrawarn out of tools/scripts/Makefile.include, etc, to better mimic what is in the kernel sources :-) Thanks, - Arnaldo > Signed-off-by: Tian Tao <tiant...@hisilicon.com> > --- > tools/perf/Makefile.config | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > index ce8516e..b9e8634 100644 > --- a/tools/perf/Makefile.config > +++ b/tools/perf/Makefile.config > @@ -16,7 +16,7 @@ $(shell printf "" > $(OUTPUT).config-detected) > detected = $(shell echo "$(1)=y" >> $(OUTPUT).config-detected) > detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected) > > -CFLAGS := $(EXTRA_CFLAGS) $(filter-out -Wnested-externs,$(EXTRA_WARNINGS)) > +CFLAGS := $(EXTRA_CFLAGS) $(EXTRA_WARNINGS) > > include $(srctree)/tools/scripts/Makefile.arch > > -- > 2.7.4 > -- - Arnaldo
