Hi Alex, I love your patch! Perhaps something to improve:
[auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Alex-Elder/net-ipa-GSI-interrupt-handling-fixes/20201223-020409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2575bc1aa9d52a62342b57a0b7d0a12146cf6aed config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4073b68cee8a9d0dbb83080db22255fc9b9d7fd5 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Alex-Elder/net-ipa-GSI-interrupt-handling-fixes/20201223-020409 git checkout 4073b68cee8a9d0dbb83080db22255fc9b9d7fd5 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): drivers/net/ipa/gsi.c: In function 'gsi_channel_alloc_command': >> drivers/net/ipa/gsi.c:496:6: warning: variable 'ret' set but not used >> [-Wunused-but-set-variable] 496 | int ret; | ^~~ drivers/net/ipa/gsi.c: In function 'gsi_channel_start_command': drivers/net/ipa/gsi.c:524:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 524 | int ret; | ^~~ drivers/net/ipa/gsi.c: In function 'gsi_channel_stop_command': drivers/net/ipa/gsi.c:552:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 552 | int ret; | ^~~ drivers/net/ipa/gsi.c: In function 'gsi_channel_reset_command': drivers/net/ipa/gsi.c:591:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 591 | int ret; | ^~~ drivers/net/ipa/gsi.c: In function 'gsi_channel_de_alloc_command': drivers/net/ipa/gsi.c:620:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 620 | int ret; | ^~~ vim +/ret +496 drivers/net/ipa/gsi.c 650d1603825d8ba Alex Elder 2020-03-05 489 650d1603825d8ba Alex Elder 2020-03-05 490 /* Allocate GSI channel in NOT_ALLOCATED state */ 650d1603825d8ba Alex Elder 2020-03-05 491 static int gsi_channel_alloc_command(struct gsi *gsi, u32 channel_id) 650d1603825d8ba Alex Elder 2020-03-05 492 { 650d1603825d8ba Alex Elder 2020-03-05 493 struct gsi_channel *channel = &gsi->channel[channel_id]; a442b3c7554898f Alex Elder 2020-06-30 494 struct device *dev = gsi->dev; a2003b303875b41 Alex Elder 2020-04-30 495 enum gsi_channel_state state; 650d1603825d8ba Alex Elder 2020-03-05 @496 int ret; 650d1603825d8ba Alex Elder 2020-03-05 497 650d1603825d8ba Alex Elder 2020-03-05 498 /* Get initial channel state */ a2003b303875b41 Alex Elder 2020-04-30 499 state = gsi_channel_state(channel); a442b3c7554898f Alex Elder 2020-06-30 500 if (state != GSI_CHANNEL_STATE_NOT_ALLOCATED) { f8d3bdd561a7c95 Alex Elder 2020-11-19 501 dev_err(dev, "channel %u bad state %u before alloc\n", f8d3bdd561a7c95 Alex Elder 2020-11-19 502 channel_id, state); 650d1603825d8ba Alex Elder 2020-03-05 503 return -EINVAL; a442b3c7554898f Alex Elder 2020-06-30 504 } 650d1603825d8ba Alex Elder 2020-03-05 505 650d1603825d8ba Alex Elder 2020-03-05 506 ret = gsi_channel_command(channel, GSI_CH_ALLOCATE); a2003b303875b41 Alex Elder 2020-04-30 507 4073b68cee8a9d0 Alex Elder 2020-12-22 508 /* If successful the channel state will have changed */ a2003b303875b41 Alex Elder 2020-04-30 509 state = gsi_channel_state(channel); 4073b68cee8a9d0 Alex Elder 2020-12-22 510 if (state == GSI_CHANNEL_STATE_ALLOCATED) 4073b68cee8a9d0 Alex Elder 2020-12-22 511 return 0; 4073b68cee8a9d0 Alex Elder 2020-12-22 512 f8d3bdd561a7c95 Alex Elder 2020-11-19 513 dev_err(dev, "channel %u bad state %u after alloc\n", f8d3bdd561a7c95 Alex Elder 2020-11-19 514 channel_id, state); 650d1603825d8ba Alex Elder 2020-03-05 515 4073b68cee8a9d0 Alex Elder 2020-12-22 516 return -EIO; 650d1603825d8ba Alex Elder 2020-03-05 517 } 650d1603825d8ba Alex Elder 2020-03-05 518 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
