From: Zhang Qilong <zhangqilo...@huawei.com>

[ Upstream commit e5548b05631ec3e6bfdaef1cad28c799545b791b ]

usb_create_hcd will alloc memory for hcd, and we should
call usb_put_hcd to free it when adding fails to prevent
memory leak.

Fixes: b92a78e582b1a ("usb host: Oxford OXU210HP HCD driver")
Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Zhang Qilong <zhangqilo...@huawei.com>
Link: https://lore.kernel.org/r/20201123145809.1456541-1-zhangqilo...@huawei.com
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/usb/host/oxu210hp-hcd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c
index 4e4d601af35c1..2f48da0c0bb39 100644
--- a/drivers/usb/host/oxu210hp-hcd.c
+++ b/drivers/usb/host/oxu210hp-hcd.c
@@ -3734,8 +3734,10 @@ static struct usb_hcd *oxu_create(struct platform_device 
*pdev,
        oxu->is_otg = otg;
 
        ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
-       if (ret < 0)
+       if (ret < 0) {
+               usb_put_hcd(hcd);
                return ERR_PTR(ret);
+       }
 
        device_wakeup_enable(hcd->self.controller);
        return hcd;
-- 
2.27.0



Reply via email to