From: Qinglang Miao <miaoqingl...@huawei.com>

[ Upstream commit 62eebd5247c4e4ce08826ad5995cf4dd7ce919dd ]

Add the missing destroy_workqueue() before return from __qedi_probe in the
error handling case when fails to create workqueue qedi->offload_thread.

Link: https://lore.kernel.org/r/20201109091518.55941-1-miaoqingl...@huawei.com
Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver 
framework.")
Reviewed-by: Mike Christie <michael.chris...@oracle.com>
Signed-off-by: Qinglang Miao <miaoqingl...@huawei.com>
Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/scsi/qedi/qedi_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 24b945b555ba3..a742b88567762 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -2387,7 +2387,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
                        QEDI_ERR(&qedi->dbg_ctx,
                                 "Unable to start offload thread!\n");
                        rc = -ENODEV;
-                       goto free_cid_que;
+                       goto free_tmf_thread;
                }
 
                /* F/w needs 1st task context memory entry for performance */
@@ -2407,6 +2407,8 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
 
        return 0;
 
+free_tmf_thread:
+       destroy_workqueue(qedi->tmf_thread);
 free_cid_que:
        qedi_release_cid_que(qedi);
 free_uio:
-- 
2.27.0



Reply via email to