[PATCH 5.4 123/453] spi: sprd: fix reference leak in sprd_spi_remove

[Greg Kroah-Hartman]

From: Zhang Qilong <zhangqilo...@huawei.com>

[ Upstream commit e4062765bc2a41e025e29dd56bad798505036427 ]

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in sprd_spi_remove, so we should fix it.

Fixes: e7d973a31c24b ("spi: sprd: Add SPI driver for Spreadtrum SC9860")
Signed-off-by: Zhang Qilong <zhangqilo...@huawei.com>
Acked-by: Chunyan Zhang <zhang.l...@gmail.com>
Link: https://lore.kernel.org/r/20201106015035.139574-1-zhangqilo...@huawei.com
Signed-off-by: Mark Brown <broo...@kernel.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/spi/spi-sprd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c
index e60aff9903951..c2bdf19ccdd26 100644
--- a/drivers/spi/spi-sprd.c
+++ b/drivers/spi/spi-sprd.c
@@ -1008,6 +1008,7 @@ static int sprd_spi_remove(struct platform_device *pdev)
 
        ret = pm_runtime_get_sync(ss->dev);
        if (ret < 0) {
+               pm_runtime_put_noidle(ss->dev);
                dev_err(ss->dev, "failed to resume SPI controller\n");
                return ret;
        }
-- 
2.27.0