From: Wang Li <wangl...@huawei.com>

[ Upstream commit 51e339deab1e51443f6ac3b1bd5cd6cc8e8fe1d9 ]

pm_runtime_enable() will decrease power disable depth. Thus a pairing
increment is needed on the error handling path to keep it balanced.

Fixes: 5d8042e95fd4 ("phy: rcar-gen3-usb2: Add support for r8a77470")
Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Wang Li <wangl...@huawei.com>
Link: https://lore.kernel.org/r/20201126024412.4046845-1-wangl...@huawei.com
Signed-off-by: Vinod Koul <vk...@kernel.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/phy/renesas/phy-rcar-gen3-usb2.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c 
b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
index 5087b7c44d55b..cfb98bba7715b 100644
--- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
+++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
@@ -654,8 +654,10 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device 
*pdev)
         */
        pm_runtime_enable(dev);
        phy_usb2_ops = of_device_get_match_data(dev);
-       if (!phy_usb2_ops)
-               return -EINVAL;
+       if (!phy_usb2_ops) {
+               ret = -EINVAL;
+               goto error;
+       }
 
        mutex_init(&channel->lock);
        for (i = 0; i < NUM_OF_PHYS; i++) {
-- 
2.27.0



Reply via email to