On Fri, Jan 01, 2021 at 11:37:18AM +0800, Gao Yan wrote: > In tty layer, it provides tty->ldisc_sem to protect all tty_ldisc_ops > including ppp_sync_ldisc. So I think tty->ldisc_sem can also > protect tty->disc_data, and the disc_data_lock is not necessary. > > Signed-off-by: Gao Yan <gao.y...@h3c.com> > --- > drivers/net/ppp/ppp_async.c | 11 ++--------- > drivers/net/ppp/ppp_synctty.c | 12 ++---------- > 2 files changed, 4 insertions(+), 19 deletions(-)
What changed from v1? And how did you test this? Why remove this lock, is it causing problems somewhere for it to be here? thanks, greg k-h
