Hi Daniel, On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: > >>> +#define CIO2_NUM_PORTS 4 > > > > This is already defined in ipu3-cio2.h. Could you include that instead? > > Yes; but I'd need to also include media/v4l2-device.h and > media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the > moment). It didn't seem worth it; but I can move those two includes from > the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h > > Which do you prefer?
Seems you got answers already... :-) splitting the header in two seems good to me. But IMO it doesn't have to be a part of this set. -- Sakari Ailus
