On Sun, 3 Jan 2021, Arnd Bergmann wrote:
> From: Arnd Bergmann <a...@arndb.de>
>
> The new driver uses a phys_addr_t to store a DMA address,
> which does not work when the two are different size:
>
> drivers/hid/amd-sfh-hid/amd_sfh_client.c:157:11: error: incompatible pointer
> types passing 'phys_addr_t *' (aka 'unsigned int *') to parameter of type
> 'dma_addr_t *' (aka 'unsigned long long *')
> [-Werror,-Wincompatible-pointer-types]
>
> &cl_data->sensor_phys_addr[i],
>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/dma-mapping.h:393:15: note: passing argument to parameter
> 'dma_handle' here
> dma_addr_t *dma_handle, gfp_t gfp)
> ^
>
> Change both the type and the variable name to dma_addr for consistency.
>
> Fixes: 4b2c53d93a4b ("SFH:Transport Driver to add support of AMD Sensor
> Fusion Hub (SFH)")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
Good catch; queued for 5.11, thanks.
--
Jiri Kosina
SUSE Labs
