On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > DT properties which can have multiple entries need to specify what the > entries are and define how many entries there can be. In the case of > only a single entry, just 'maxItems: 1' is sufficient. > > Add the missing entry constraints. These were found with a modified > meta-schema. Unfortunately, there are a few cases where the size > constraints are not defined such as common bindings, so the meta-schema > can't be part of the normal checks. > > Cc: Jens Axboe <ax...@kernel.dk> > Cc: Stephen Boyd <sb...@kernel.org> > Cc: Thierry Reding <thierry.red...@gmail.com> > Cc: MyungJoo Ham <myungjoo....@samsung.com> > Cc: Chanwoo Choi <cw00.c...@samsung.com> > Cc: Linus Walleij <linus.wall...@linaro.org> > Cc: Bartosz Golaszewski <bgolaszew...@baylibre.com> > Cc: Jonathan Cameron <ji...@kernel.org> > Cc: Dmitry Torokhov <dmitry.torok...@gmail.com> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Marc Zyngier <m...@kernel.org> > Cc: Mauro Carvalho Chehab <mche...@kernel.org> > Cc: Chen-Yu Tsai <w...@csie.org> > Cc: Ulf Hansson <ulf.hans...@linaro.org> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: Jakub Kicinski <k...@kernel.org> > Cc: Sebastian Reichel <s...@kernel.org> > Cc: Ohad Ben-Cohen <o...@wizery.com> > Cc: Bjorn Andersson <bjorn.anders...@linaro.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Signed-off-by: Rob Herring <r...@kernel.org>
<snip> > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > index 247ef00381ea..f76b25f7fc7a 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > @@ -83,6 +83,7 @@ properties: > Phandle of a companion. > > phys: > + maxItems: 1 > description: PHY specifier for the USB PHY > > phy-names: > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > index 2178bcc401bc..8e2bd61f2075 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > @@ -71,6 +71,7 @@ properties: > Overrides the detected port count > > phys: > + maxItems: 1 > description: PHY specifier for the USB PHY > > phy-names: > diff --git a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > index 678396eeeb78..f506225a4d57 100644 > --- a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > +++ b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > @@ -40,7 +40,7 @@ properties: > - const: mc > > phys: > - description: PHY specifier for the USB PHY > + maxItems: 1 > > usb-role-switch: > type: boolean Any reason you dropped the description for this entry, but not the other ones above? > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > index 388245b91a55..adce36e48bc9 100644 > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > @@ -15,13 +15,14 @@ properties: > - const: ti,j721e-usb > > reg: > - description: module registers > + maxItems: 1 > > power-domains: > description: > PM domain provider node and an args specifier containing > the USB device id value. See, > Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > + maxItems: 1 > > clocks: > description: Clock phandles to usb2_refclk and lpm_clk Same here, why remove the description? thanks, greg k-h