Tianjia Zhang <[email protected]> wrote: > On the following call path, `sig->pkey_algo` is not assigned > in asymmetric_key_verify_signature(), which causes runtime > crash in public_key_verify_signature(). > > keyctl_pkey_verify > asymmetric_key_verify_signature > verify_signature > public_key_verify_signature > > This patch simply check this situation and fixes the crash > caused by NULL pointer. > > Fixes: 215525639631 ("X.509: support OSCCA SM2-with-SM3 certificate > verification") > Cc: [email protected] # v5.10+ > Reported-by: Tobias Markus <[email protected]> > Signed-off-by: Tianjia Zhang <[email protected]>
Looks reasonable: Acked-by: David Howells <[email protected]> I wonder, though, if cert_sig_digest_update() should be obtained by some sort of function pointer. It doesn't really seem to belong in this file. But this is a separate issue. David
