On Sat, Jan 09, 2021 at 02:08:53PM -0800, Tom Rix wrote:
>
> On 12/28/20 5:51 AM, Zheng Yongjun wrote:
> > spinlock can be initialized automatically with DEFINE_SPINLOCK()
> > rather than explicitly calling spin_lock_init().
> >
> > Signed-off-by: Zheng Yongjun <zhengyongj...@huawei.com>
>
> This looks fine.
>
> Reviewed-by: Tom Rix <t...@redhat.com>
>
> > ---
> > drivers/fpga/fpga-bridge.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
> > index 2deccacc3aa7..e9266b2a357f 100644
> > --- a/drivers/fpga/fpga-bridge.c
> > +++ b/drivers/fpga/fpga-bridge.c
> > @@ -17,7 +17,7 @@ static DEFINE_IDA(fpga_bridge_ida);
> > static struct class *fpga_bridge_class;
> >
> > /* Lock for adding/removing bridges to linked lists*/
> > -static spinlock_t bridge_list_lock;
> > +static DEFINE_SPINLOCK(bridge_list_lock);
> >
> > /**
> > * fpga_bridge_enable - Enable transactions on the bridge
> > @@ -479,8 +479,6 @@ static void fpga_bridge_dev_release(struct device *dev)
> >
> > static int __init fpga_bridge_dev_init(void)
> > {
> > - spin_lock_init(&bridge_list_lock);
> > -
> > fpga_bridge_class = class_create(THIS_MODULE, "fpga_bridge");
> > if (IS_ERR(fpga_bridge_class))
> > return PTR_ERR(fpga_bridge_class);
>
Applied,
Thanks
