On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote: > > +#define READ_SC(p, r) readb ((p)->membase + RD_##r) > > +#define WRITE_SC(p, r, v) writeb ((v), (p)->membase + WR_##r) > > No space before the (. checkpatch misses this.
Yep, over careful in the special case for the parameters for #define macros, which have different spacing rules. This will be fixed in 0.13: WARNING: no space between function name and open parenthesis '(' #1: FILE: Z45.c:1: +#define WRITE_SC(p, r, v) writeb ((v), (p)->membase + WR_##r) -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/