On Mon, Dec 24, 2007 at 01:43:53PM +1100, Stephen Rothwell wrote: > Hi Balbir, > > Thanks for the report. > > On Mon, 24 Dec 2007 04:11:58 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > > > > I see the following error with the iseries_veth driver in 2.6.24-rc6-mm1 > > > > drivers/net/iseries_veth.c: In function ‘veth_init_connection’: > > drivers/net/iseries_veth.c:818: warning: unused variable ‘rc’ > > drivers/net/iseries_veth.c: In function ‘veth_probe_one’: > > drivers/net/iseries_veth.c:1086: error: ‘veth_port_ktypeq’ undeclared > > (first use in this function) > > drivers/net/iseries_veth.c:1086: error: (Each undeclared identifier is > > reported only once > > drivers/net/iseries_veth.c:1086: error: for each function it appears > > in.) > > make[2]: *** [drivers/net/iseries_veth.o] Error 1 > > make[1]: *** [drivers/net] Error 2 > > make: *** [drivers] Error 2
Thanks for the report, sorry for the typos, I'll fix up my patch. > Yeah, that would be > gregkh-driver-kobject-convert-drivers-net-iseries_vethc-to-use-kobject_init-add_ng. > > Hi Greg, do you even build with your patches applied? For the power architecture, no, I do not. I used to, but my cross-build box died and I haven't taken the time to set it all up again. For i386 and x86-64 I do build everything, and as that's 99% of the users, it's usually fine :) I did start to try to get a s390 cross-build working, but ran out of time a week or so ago... > > Here's a patch, compile tested to fix the compilation problem > > Hopefully Greg will fix his original patch before it reaches Linus. I will do that. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/