On Thu, Jan 14, 2021 at 11:46:40PM +0800, Leo Yan wrote: > This patch series is for several minor code refactoring, which is > extracted from the patch series "perf c2c: Sort cacheline with all > loads" [1]. > > There has a known issue for Arm SPE store operations and Arm SPE is > the only consumer for soring with all loads, this is the reason in this > series drops the changes for dimensions and sorting, and only extracts > the patches related with code refactoring. So this series doesn't > introduce any functionality change. > > The patches have been tested on x86_64 and compared the result before > and after applying the patches, and confirmed no difference for the > output result. > > Changes from v3: > * Refined patch 03/06 to remove unnecessary parentheses and test and > return early in the function filter_display() (Joe Perches); > * Added new patch 04/06 to make argument type as u32 for percent().
Acked-by: Jiri Olsa <jo...@redhat.com> thanks, jirka > > Changes from v2: > * Changed to use static functions to replace macros (Namhyung); > * Added Jiri's Ack tags in the unchanged patches; > * Minor improvement in the commit logs. > > [1] https://lore.kernel.org/patchwork/cover/1353064/ > > > Leo Yan (6): > perf c2c: Rename for shared cache line stats > perf c2c: Refactor hist entry validation > perf c2c: Refactor display filter > perf c2c: Fix argument type for percent() > perf c2c: Refactor node display > perf c2c: Add local variables for output metrics > > tools/perf/builtin-c2c.c | 168 +++++++++++++++++++++++---------------- > 1 file changed, 99 insertions(+), 69 deletions(-) > > -- > 2.25.1 >
