From: Christophe JAILLET <christophe.jail...@wanadoo.fr>

commit d645148cc82ca7fbacaa601414a552184e9c6dd3 upstream.

'disable_xdmac()' should be called in the error handling path of the
probe function to undo a previous 'enable_xdmac()' call, as already
done in the remove function.

Fixes: a6e9be055d47 ("dmaengine: milbeaut-xdmac: Add XDMAC driver for Milbeaut 
platforms")
Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
Link: 
https://lore.kernel.org/r/20201219132800.183254-1-christophe.jail...@wanadoo.fr
Signed-off-by: Vinod Koul <vk...@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 drivers/dma/milbeaut-xdmac.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/dma/milbeaut-xdmac.c
+++ b/drivers/dma/milbeaut-xdmac.c
@@ -351,7 +351,7 @@ static int milbeaut_xdmac_probe(struct p
 
        ret = dma_async_device_register(ddev);
        if (ret)
-               return ret;
+               goto disable_xdmac;
 
        ret = of_dma_controller_register(dev->of_node,
                                         of_dma_simple_xlate, mdev);
@@ -364,6 +364,8 @@ static int milbeaut_xdmac_probe(struct p
 
 unregister_dmac:
        dma_async_device_unregister(ddev);
+disable_xdmac:
+       disable_xdmac(mdev);
        return ret;
 }
 


Reply via email to