Re: [PATCH 6/9] arm64: dts: imx8mq-librem5: enable the LCD panel

[Shawn Guo]

On Tue, Jan 12, 2021 at 10:51:48AM +0100, Martin Kepplinger wrote:
> This enables the Librem5's ft8006p based LCD panel driven by the
> imx8mq's Northwest Logic DSI IP core and mxsfb display controller.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplin...@puri.sm>
> ---
>  .../boot/dts/freescale/imx8mq-librem5.dtsi    | 51 ++++++++++++++++++-
>  1 file changed, 49 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi 
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index f77b51d3c132..440931f81c12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -310,6 +310,17 @@
>               >;
>       };
>  
> +     pinctrl_dsirst: dsirstgrp {
> +             fsl,pins = <
> +                     /* DSI_RST */
> +                     MX8MQ_IOMUXC_ENET_RD3_GPIO1_IO29        0x83
> +                     /* DSI_TE */
> +                     MX8MQ_IOMUXC_ENET_RD2_GPIO1_IO28        0x83
> +                     /* TP_RST */
> +                     MX8MQ_IOMUXC_ENET_RX_CTL_GPIO1_IO24     0x83
> +             >;
> +     };
> +
>       pinctrl_ecspi1: ecspigrp {
>               fsl,pins = <
>                       MX8MQ_IOMUXC_ECSPI1_MOSI_ECSPI1_MOSI    0x83
> @@ -817,12 +828,12 @@
>               compatible = "tps65132";
>               reg = <0x3e>;
>  
> -             outp {
> +             reg_lcd_avdd: outp {
>                       regulator-name = "LCD_AVDD";
>                       vin-supply = <&reg_lcd_3v4>;
>               };
>  
> -             outn {
> +             reg_lcd_avee: outn {
>                       regulator-name = "LCD_AVEE";
>                       vin-supply = <&reg_lcd_3v4>;
>               };
> @@ -947,6 +958,42 @@
>       };
>  };
>  
> +&lcdif {
> +     status = "okay";
> +};
> +
> +&mipi_dsi {
> +     status = "okay";
> +     #address-cells = <1>;
> +     #size-cells = <0>;

Please end property list with `status`.

> +
> +     lcd_panel: panel@0 {
> +             compatible = "mantix,mlaf057we51-x";
> +             reg = <0>;
> +             pinctrl-names = "default";
> +             pinctrl-0 = <&pinctrl_dsirst>;
> +             avdd-supply = <&reg_lcd_avdd>;
> +             avee-supply = <&reg_lcd_avee>;
> +             vddi-supply = <&reg_lcd_1v8>;
> +             backlight = <&backlight_dsi>;
> +             reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;

Have a newline between properties and child node.

> +             port {
> +                     panel_in: endpoint {
> +                             remote-endpoint = <&mipi_dsi_out>;
> +                     };
> +             };
> +     };
> +
> +     ports {
> +             port@1 {
> +                     reg = <1>;

Ditto

Shawn

> +                     mipi_dsi_out: endpoint {
> +                             remote-endpoint = <&panel_in>;
> +                     };
> +             };
> +     };
> +};
> +
>  &pgc_gpu {
>       power-supply = <&buck3_reg>;
>  };
> -- 
> 2.20.1
>