On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnef...@arm.com wrote: > @@ -157,26 +162,24 @@ static int cpuhp_invoke_callback(unsigned int cpu, enum > cpuhp_state state, > > if (st->fail == state) { > st->fail = CPUHP_INVALID; > - > - if (!(bringup ? step->startup.single : step->teardown.single)) > - return 0; > - > return -EAGAIN; > } > > + if (cpuhp_step_empty(bringup, step)) { > + WARN_ON_ONCE(1); > + return 0; > + }
This changes the behaviour of fail.. might be best to refactor without changing behaviour. Lemme continue reading.