Hi Huaixin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on tip/master linux/master linus/master v5.11-rc4 
next-20210120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 
65bcf072e20ed7597caa902f170f293662b0af3c
config: c6x-randconfig-r035-20210120 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/a62cc8421988be29990ad86e33e877fb8776f8bd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731
        git checkout a62cc8421988be29990ad86e33e877fb8776f8bd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/sched/fair.c:4623:6: warning: no previous prototype for 
>> '__refill_cfs_bandwidth_runtime' [-Wmissing-prototypes]
    4623 | void __refill_cfs_bandwidth_runtime(struct cfs_bandwidth *cfs_b, u64 
overrun)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/__refill_cfs_bandwidth_runtime +4623 kernel/sched/fair.c

  4615  
  4616  /*
  4617   * Replenish runtime according to assigned quota. We use sched_clock_cpu
  4618   * directly instead of rq->clock to avoid adding additional 
synchronization
  4619   * around rq->lock.
  4620   *
  4621   * requires cfs_b->lock
  4622   */
> 4623  void __refill_cfs_bandwidth_runtime(struct cfs_bandwidth *cfs_b, u64 
> overrun)
  4624  {
  4625          u64 refill;
  4626  
  4627          if (cfs_b->quota != RUNTIME_INF) {
  4628  
  4629                  if (!sysctl_sched_cfs_bw_burst_enabled) {
  4630                          cfs_b->runtime = cfs_b->quota;
  4631                          return;
  4632                  }
  4633  
  4634                  overrun = min(overrun, cfs_b->max_overrun);
  4635                  refill = cfs_b->quota * overrun;
  4636                  cfs_b->runtime += refill;
  4637                  cfs_b->runtime = min(cfs_b->runtime, cfs_b->buffer);
  4638          }
  4639  }
  4640  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to