Re: [PATCH] drm/ast: Update the sequence of Clearing Fast-reset

[Thomas Zimmermann]

Hi

Am 18.01.21 um 09:57 schrieb KuoHsiang Chou:

[Bug][AST2500]
If SCU00 is not unlocked, just enter its password again.
It is unnecessary to clear AHB lock condition and restore WDT default
setting again, before Fast-reset clearing.

Signed-off-by: KuoHsiang Chou <kuohsiang_c...@aspeedtech.com>

Best regards
Thomas

Is this a separate issue? This patch looks like a fix for the previous patch. [1] Can you add this change to v3 of the other patch? [1] https://lore.kernel.org/dri-devel/20210112075811.9354-1-kuohsiang_c...@aspeedtech.com/

---
  drivers/gpu/drm/ast/ast_post.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast/ast_post.c
index 1f0007daa005..4f194c5fd2c2 100644
--- a/drivers/gpu/drm/ast/ast_post.c
+++ b/drivers/gpu/drm/ast/ast_post.c
@@ -2030,7 +2030,6 @@ void ast_patch_ahb_2500(struct ast_private *ast)
  {
        u32     data;

-patch_ahb_lock:
        /* Clear bus lock condition */
        ast_moutdwm(ast, 0x1e600000, 0xAEED1A03);
        ast_moutdwm(ast, 0x1e600084, 0x00010000);
@@ -2044,11 +2043,9 @@ void ast_patch_ahb_2500(struct ast_private *ast)
                ast_moutdwm(ast, 0x1E78500c, 0x00000033);
                udelay(1000);
        }
-       ast_moutdwm(ast, 0x1e6e2000, 0x1688A8A8);
        do {
+               ast_moutdwm(ast, 0x1e6e2000, 0x1688A8A8);
                data = ast_mindwm(ast, 0x1e6e2000);
-               if (data == 0xffffffff)
-                       goto patch_ahb_lock;
        }       while (data != 1);
        ast_moutdwm(ast, 0x1e6e207c, 0x08000000);       /* clear fast reset */
  }
--
2.18.4

_______________________________________________
dri-devel mailing list
dri-de...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

OpenPGP_signature
Description: OpenPGP digital signature