Dear Chunyou, On 2021/01/21 17:41, Luca Ceresoli wrote: > Hi, > > On 21/01/21 04:21, Chunyou Tang wrote: >> On Wed, 20 Jan 2021 19:09:05 -0800 >> Joe Perches <j...@perches.com> wrote: >> >>> On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote: >>>> On 1/20/21 6:07 PM, ChunyouTang wrote: >>>>> From: tangchunyou <tangchun...@yulong.com> >>>>> >>>>> Increase direcly,maping,manger spelling error check >>>> >>>> Hi, >>>> I don't see all of those in the patch below. >>>> What happened? >>> >>> I think mostly it's just a poor commit message as >>> direcly and manger are already in spelling.txt >>> >>>>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt >>> [] >>>>> @@ -875,6 +875,7 @@ manger||manager >>>>> ?0?2manoeuvering||maneuvering >>>>> ?0?2manufaucturing||manufacturing >>>>> ?0?2mappping||mapping >>>>> +maping||mapping >>>>> ?0?2matchs||matches >>>>> ?0?2mathimatical||mathematical >>>>> ?0?2mathimatic||mathematic >>> >> >> yes,you are right,the commit message is bad,I change the commit message >> >> and resend it. > > While doing that, also improve the subject (1st line of commit message) > by mentioning the typo you are adding. For example, as in previous commits: > > scripts/spelling.txt: add "maping" typo > > It's more informative and even shorter. > > Thanks >
Rules in scripts/spelling.txt are sorted alphabetically by leftside words. It would be better that you insert "maping||mapping" rule between: "manufaucturing||manufacturing" and "mappping||mapping" . Best regards, Naoki Hayama
