Hi John, On Wed, 20 Jan 2021 at 02:15, John Stultz <[email protected]> wrote: > > If we abort from the allocation due to a fatal_signal_pending(), > be sure we report an error so any return code paths don't trip > over the fact that the allocation didn't succeed.
Thanks for the patch; LGTM, will push into drm-misc-next. > > Cc: Sumit Semwal <[email protected]> > Cc: Liam Mark <[email protected]> > Cc: Laura Abbott <[email protected]> > Cc: Brian Starkey <[email protected]> > Cc: Hridya Valsaraju <[email protected]> > Cc: Suren Baghdasaryan <[email protected]> > Cc: Sandeep Patil <[email protected]> > Cc: Daniel Mentz <[email protected]> > Cc: Chris Goldsworthy <[email protected]> > Cc: Ørjan Eide <[email protected]> > Cc: Robin Murphy <[email protected]> > Cc: Ezequiel Garcia <[email protected]> > Cc: Simon Ser <[email protected]> > Cc: James Jones <[email protected]> > Cc: [email protected] > Cc: [email protected] > Suggested-by: Suren Baghdasaryan <[email protected]> > Signed-off-by: John Stultz <[email protected]> > --- > drivers/dma-buf/heaps/system_heap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma-buf/heaps/system_heap.c > b/drivers/dma-buf/heaps/system_heap.c > index 17e0e9a68baf..405351aad2a8 100644 > --- a/drivers/dma-buf/heaps/system_heap.c > +++ b/drivers/dma-buf/heaps/system_heap.c > @@ -363,8 +363,10 @@ static int system_heap_allocate(struct dma_heap *heap, > * Avoid trying to allocate memory if the process > * has been killed by SIGKILL > */ > - if (fatal_signal_pending(current)) > + if (fatal_signal_pending(current)) { > + ret = -EINTR; > goto free_buffer; > + } > > page = alloc_largest_available(size_remaining, max_order); > if (!page) > -- > 2.17.1 > Best, Sumit.
