On 1/21/21 9:51 PM, Christophe Leroy wrote:
>
>
> Le 22/01/2021 à 02:08, Randy Dunlap a écrit :
>> Fix missing export for a loadable module build:
>>
>> ERROR: modpost: "cpm_setbrg" [drivers/tty/serial/cpm_uart/cpm_uart.ko]
>> undefined!
>>
>> Fixes: 4128a89ac80d ("powerpc/8xx: move CPM1 related files from sysdev/ to
>> platforms/8xx")
>
> I don't understand. Before that commit cpm_setbrg() wasn't exported either.
>
> For me, it fixes the commit that brought the capability to build the cpm uart
> driver as a module, that is commit 1da177e4c3f4 ("Linux-2.6.12-rc")
OK, I didn't have a lot of confidence in that tag.
Thanks for commenting.
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Reported-by: kernel test robot <[email protected]>
>> Cc: Nick Desaulniers <[email protected]>
>> Cc: [email protected]
>> Cc: Andrew Morton <[email protected]>
>> Cc: Christophe Leroy <[email protected]>
>> Cc: Michael Ellerman <[email protected]>
>> Cc: Benjamin Herrenschmidt <[email protected]>
>> Cc: Paul Mackerras <[email protected]>
>> Cc: [email protected]
>> ---
>> arch/powerpc/platforms/8xx/cpm1.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20210121.orig/arch/powerpc/platforms/8xx/cpm1.c
>> +++ linux-next-20210121/arch/powerpc/platforms/8xx/cpm1.c
>> @@ -280,6 +280,7 @@ cpm_setbrg(uint brg, uint rate)
>> out_be32(bp, (((BRG_UART_CLK_DIV16 / rate) - 1) << 1) |
>> CPM_BRG_EN | CPM_BRG_DIV16);
>> }
>> +EXPORT_SYMBOL(cpm_setbrg);
>> struct cpm_ioport16 {
>> __be16 dir, par, odr_sor, dat, intr;
>>
--
~Randy
RFC: Features and documentation: http://lwn.net/Articles/260136/
