Mostly just stylistic comments from me here. On Monday 24 December 2007 03:06:37 [EMAIL PROTECTED] wrote: > From: Alex Dubov <[EMAIL PROTECTED]> > > Sony MemoryStick cards are used in many products manufactured by Sony. They > are available both as storage and as IO expansion cards. Currently, only > MemoryStick Pro storage cards are supported via TI FlashMedia MemoryStick > interface. > > Signed-off-by: Alex Dubov <[EMAIL PROTECTED]>
For MemoryStick Pro on my TI7421 card reader (since my old MemoryStick card and camera have disappeared somewhere, so I cannot currently test that): Tested-by: Carlos Corbacho <[EMAIL PROTECTED]> However, my only concerns are that: 1) tifm_ms was not autoloaded 2) On loading tifm_ms, only memstick was autoloaded - mspro_block was not. Although, whether this is an issue with userspace (ie. udev) not dealing with the modules properly, I don't know. > --- /dev/null > +++ b/drivers/memstick/core/memstick.c > @@ -0,0 +1,557 @@ > +/* > + * memstick.c - Sony MemoryStick support File names in comments are now frowned upon - there was a thread on this in October on LKML: http://lkml.org/lkml/2007/10/12/524 Also, before Andrew gets in with this - you should run this through checkpatch, as there are a few errors it throws up (mostly foo* and C99 comments). -Carlos -- E-Mail: [EMAIL PROTECTED] Web: strangeworlds.co.uk GPG Key ID: 0x23EE722D -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
