On Sat, Jan 23, 2021 at 4:44 AM Stephen Boyd <[email protected]> wrote: > > This effectively reverts 1db73ae39a97 ("of/device: Nullify match table > in of_match_device() for CONFIG_OF=n") because that commit makes it more > surprising to users of this API that the arguments may never be > referenced by any code. This is because the pre-processor will replace > the argument with NULL and then the match table will be left unreferenced > by any code but the compiler optimizer doesn't know to drop it. This can > lead to compilers warning that match tables are unused, when we really > want to pass the match table to the API but have the compiler see that > it's all inlined and not used and then drop the match table while > silencing the warning. We're being too smart here and not giving the > compiler the chance to do dead code elimination. > > Signed-off-by: Stephen Boyd <[email protected]> > Acked-by: Frank Rowand <[email protected]> > Cc: Arnd Bergmann <[email protected]> > Cc: Geert Uytterhoeven <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Frank Rowand <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]>
