On Tue, 26 Jan 2021 at 05:35, David Gow <[email protected]> wrote: > > On Thu, Jan 14, 2021 at 12:06 AM Marco Elver <[email protected]> wrote: > > > > Per recently added KUnit style recommendations at > > Documentation/dev-tools/kunit/style.rst, make the following changes to > > the KCSAN test: > > > > 1. Rename 'kcsan-test.c' to 'kcsan_test.c'. > > > > 2. Rename suite name 'kcsan-test' to 'kcsan'. > > > > 3. Rename CONFIG_KCSAN_TEST to CONFIG_KCSAN_KUNIT_TEST and > > default to KUNIT_ALL_TESTS. > > > > Cc: David Gow <[email protected]> > > Signed-off-by: Marco Elver <[email protected]> > > Thanks very much -- it's great to see the naming guidelines starting > to be picked up. I also tested the KUNIT_ALL_TESTS config option w/ > KCSAN enabled, and it worked a treat. > > My only note is that we've had some problems[1] with mm-related > changes which rename files getting corrupted at some point before > reaching Linus, so it's probably worth keeping a close eye on this > change to make sure nothing goes wrong.
KCSAN changes go through Paul's -rcu tree, and once there's a stable commit (latest when it reaches -tip) I would expect Git won't mess things up. > Reviewed-by: David Gow <[email protected]> Thanks for taking a look! -- Marco > -- David > > [1]: https://www.spinics.net/lists/linux-mm/msg239149.html
