Hi!
On Wed, 2021-01-27 at 13:46 +0300, Nikita Shubin wrote:
> - use predefined constants instead of plain numbers
> - use provided bank IRQ number instead of defined constant
> for port F
>
> Signed-off-by: Nikita Shubin <nikita.shu...@maquefel.me>
Reviewed-by: Alexander Sverdlin <alexander.sverd...@gmail.com>
> ---
> drivers/gpio/gpio-ep93xx.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index b212c007240e..2aee13b5067d 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -28,6 +28,8 @@
> /* Maximum value for irq capable line identifiers */
> #define EP93XX_GPIO_LINE_MAX_IRQ 23
>
> +#define EP93XX_GPIO_A_IRQ_BASE 64
> +#define EP93XX_GPIO_B_IRQ_BASE 72
> /*
> * Static mapping of GPIO bank F IRQS:
> * F0..F7 (16..24) to irq 80..87.
> @@ -311,14 +313,14 @@ struct ep93xx_gpio_bank {
>
> static struct ep93xx_gpio_bank ep93xx_gpio_banks[] = {
> /* Bank A has 8 IRQs */
> - EP93XX_GPIO_BANK("A", 0x00, 0x10, 0, true, false, 64),
> + EP93XX_GPIO_BANK("A", 0x00, 0x10, 0, true, false,
> EP93XX_GPIO_A_IRQ_BASE),
> /* Bank B has 8 IRQs */
> - EP93XX_GPIO_BANK("B", 0x04, 0x14, 8, true, false, 72),
> + EP93XX_GPIO_BANK("B", 0x04, 0x14, 8, true, false,
> EP93XX_GPIO_B_IRQ_BASE),
> EP93XX_GPIO_BANK("C", 0x08, 0x18, 40, false, false, 0),
> EP93XX_GPIO_BANK("D", 0x0c, 0x1c, 24, false, false, 0),
> EP93XX_GPIO_BANK("E", 0x20, 0x24, 32, false, false, 0),
> /* Bank F has 8 IRQs */
> - EP93XX_GPIO_BANK("F", 0x30, 0x34, 16, false, true, 0),
> + EP93XX_GPIO_BANK("F", 0x30, 0x34, 16, false, true,
> EP93XX_GPIO_F_IRQ_BASE),
> EP93XX_GPIO_BANK("G", 0x38, 0x3c, 48, false, false, 0),
> EP93XX_GPIO_BANK("H", 0x40, 0x44, 56, false, false, 0),
> };
> @@ -445,7 +447,7 @@ static int ep93xx_gpio_add_bank(struct gpio_chip
> *gc,
>
> /* Only bank F has especially funky IRQ handling */
> if (bank->has_hierarchical_irq) {
> - err = ep93xx_gpio_add_f_irq_chip(pdev, girq,
> EP93XX_GPIO_F_IRQ_BASE);
> + err = ep93xx_gpio_add_f_irq_chip(pdev, girq, bank-
> >irq_base);
> if (err)
> return err;
> }
--
Alexander Sverdlin.
