On Tue, Jan 26, 2021 at 07:36:04PM -0800, David Gow wrote:
> The LiteX SOC controller driver makes use of IOMEM functions like
> devm_platform_ioremap_resource(), which are only available if
> CONFIG_HAS_IOMEM is defined.
>
> This causes the driver not to be enable under make ARCH=um allyesconfig,
> even though it won't build.
Is this wording correct? I suspect it causes to driver TO BE enabled.
>
> By adding a dependency on HAS_IOMEM, the driver will not be enabled on
> architectures which don't support it.
>
> Fixes: 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver")
> Signed-off-by: David Gow <[email protected]>a
This looks ok to me. I can queue it for 5.11 fixes, if you can help with the
wording above.
-Stafford
> ---
> drivers/soc/litex/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/litex/Kconfig b/drivers/soc/litex/Kconfig
> index 7c6b009b6f6c..7a7c38282e11 100644
> --- a/drivers/soc/litex/Kconfig
> +++ b/drivers/soc/litex/Kconfig
> @@ -8,6 +8,7 @@ config LITEX
> config LITEX_SOC_CONTROLLER
> tristate "Enable LiteX SoC Controller driver"
> depends on OF || COMPILE_TEST
> + depends on HAS_IOMEM
> select LITEX
> help
> This option enables the SoC Controller Driver which verifies
> --
> 2.30.0.280.ga3ce27912f-goog
>
