On 27-01-21, 22:40, Hsin-Yi Wang wrote: > Hi Viresh, > > I tested this patch with devfreq passive governor[1] and mt8183 > cci[2]. It's also working as expected.
I hope I can add your Tested-by for the patch then, right ? > [1] > https://patchwork.kernel.org/project/linux-pm/cover/20190724014222.110767-1-sarava...@google.com/ > (patch 2,4,5) > [2] > https://patchwork.kernel.org/project/linux-mediatek/cover/1594348284-14199-1-git-send-email-andrew-sh.ch...@mediatek.com/ > > In my testing case, required_opp_table is not genpd case (mt8183 cci > is not genpd), so I remove the following constraint. Does that make > sense to you? > > @@ -377,13 +377,6 @@ static void lazy_link_required_opp_table(struct > opp_table *new_table) > struct dev_pm_opp *opp; > int i, ret; > > - /* > - * We only support genpd's OPPs in the "required-opps" for now, > - * as we don't know much about other cases. > - */ > - if (!new_table->is_genpd) > - return; > - > mutex_lock(&opp_table_lock); We will perhaps need more changes than that, but those should be done separately when you try to add a user for the same. -- viresh
