On Thu, Jan 28, 2021 at 7:59 PM 'Nick Desaulniers' via Clang Built Linux <clang-built-li...@googlegroups.com> wrote: > On Thu, Jan 28, 2021 at 8:15 AM Arnd Bergmann <a...@kernel.org> wrote: > > > Plus a lot of extra errors when building with CONFIG_THUMB2_KERNEL, > > as that uses tests in arch/arm/probes/kprobes/test-thumb.c. > > Technically, that's a distinctly separate issue; > arch/arm/probes/kprobes/test-arm.c is not built with > CONFIG_THUMB2_KERNEL=y. This patch doesn't introduce those warnings; > that file has the same issue but it is separate from test-arm.c. > > Would you prefer to see a v2 with the swpvsb fix contain fixes for > test-thumb.c as well, or a separate patch for that?
I think either way is fine. I'd probably go with a combined patch in this case, since you are addressing the same issue in two closely related files. Arnd