Hi Bryan, thank you so much for reviewing, I really appreciate it. On Sat, Jan 30, 2021 at 5:11 PM <bryan.whiteh...@microchip.com> wrote: > > > /* unmap from dma */ > > + packet_length = RX_DESC_DATA0_FRAME_LENGTH_GET_ > > + (descriptor->data0); > It appears you moved this packet_length assignment from just below the > following if block, however you left out the le32_to_cpu.See next comment >
Correct on both counts. This is a merge snafu that crept in when I rebased to Alexey's very recent little/big endian patch, at the last minute. My tests didn't catch it, because I'm running on a little-endian cpu, where le32_to_cpu() compiles to a nop. Had I had the good sense to run sparse on every patch, like Jakub has, I would have caught it...