On 13/01/2021 22:30, Enric Balletbo i Serra wrote: > Child domains can be deferred by the core because one of its resources > is not available yet, in such case, it will print an error, but > later it will succeed to probe. Fix that using the dev_err_probe() > function so it only prints an error on a real error. > > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> Applied to v5.11-next/soc Thanks > --- > > drivers/soc/mediatek/mtk-pm-domains.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-pm-domains.c > b/drivers/soc/mediatek/mtk-pm-domains.c > index ae255aa7b1a9..8055fb019ba6 100644 > --- a/drivers/soc/mediatek/mtk-pm-domains.c > +++ b/drivers/soc/mediatek/mtk-pm-domains.c > @@ -480,8 +480,8 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, > struct device_node *paren > > child_pd = scpsys_add_one_domain(scpsys, child); > if (IS_ERR(child_pd)) { > - ret = PTR_ERR(child_pd); > - dev_err(scpsys->dev, "%pOF: failed to get child domain > id\n", child); > + dev_err_probe(scpsys->dev, PTR_ERR(child_pd), > + "%pOF: failed to get child domain id\n", > child); > goto err_put_node; > } > >