2021年2月1日(月) 16:43 Jiapeng Chong <jiapeng.ch...@linux.alibaba.com>: > > Fix the following coccicheck warning: > > ./lib/fault-inject.c:187:0-23: WARNING: fops_stacktrace_depth should be > defined with DEFINE_DEBUGFS_ATTRIBUTE. > > ./lib/fault-inject.c:169:0-23: WARNING: fops_ul should be defined with > DEFINE_DEBUGFS_ATTRIBUTE. > > Reported-by: Abaci Robot <ab...@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.ch...@linux.alibaba.com> > --- > lib/fault-inject.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/fault-inject.c b/lib/fault-inject.c > index ce12621..cb7ea22 100644 > --- a/lib/fault-inject.c > +++ b/lib/fault-inject.c > @@ -166,7 +166,7 @@ static int debugfs_ul_get(void *data, u64 *val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n"); > > static void debugfs_create_ul(const char *name, umode_t mode, > struct dentry *parent, unsigned long *value)
Could you just remove this fops_ul stuff and use debugfs_create_ulong() instead?