On Tue, Feb 02, 2021 at 03:50:28PM +0100, Mauro Carvalho Chehab wrote: > Mark Brown <broo...@kernel.org> escreveu: > > On Tue, Feb 02, 2021 at 02:29:54PM +0100, Mauro Carvalho Chehab wrote:
> > > As this is device-dependent, such regulator line should be > > > optional. > > Supplies should only be optional if they may be physically absent from > > the system, > That's the case. On Hikey 960, the PCIe hardware supported by this > driver doesn't require any regulator. > On Hikey 970, the PCIe hardware is more complex. Some components > are outside the SoC, and those require a regulator to be powered > up. That's not an optional supply, that's a required supply for a different device. The driver should select which supplies it is requesting based on the hardware it's controlling.
signature.asc
Description: PGP signature
