On Sat, Jan 20 2001, Andrea Arcangeli wrote: > On Sat, Jan 20, 2001 at 06:41:06PM +0100, [EMAIL PROTECTED] wrote: > > hi, > > > > got this oops when doing a > > vgextend -v vgroot /dev/ide/host2/bus0/target0/lun0/part2 \ > > /dev/ide/host2/bus1/target0/lun0/part2 > > You should upgrade to 0.9.1_beta2 that should merge all the known fixes out > there. It's planned for inclusion into 2.4.1. If you are doing updates, could you include this patch too? All it does is waste memory. -- * Jens Axboe <[EMAIL PROTECTED]> * SuSE Labs
--- /kt/linux-2.4.1-pre9/drivers/md/lvm.c Fri Dec 29 23:07:22 2000 +++ drivers/md/lvm.c Sat Jan 20 19:50:59 2001 @@ -208,9 +208,6 @@ extern int lvm_init(void); #endif -static void lvm_dummy_device_request(request_queue_t *); -#define DEVICE_REQUEST lvm_dummy_device_request - static int lvm_make_request_fn(request_queue_t*, int, struct buffer_head*); static int lvm_blk_ioctl(struct inode *, struct file *, uint, ulong); @@ -464,7 +461,6 @@ lvm_hd_name_ptr = lvm_hd_name; #endif - blk_init_queue(BLK_DEFAULT_QUEUE(MAJOR_NR), DEVICE_REQUEST); blk_queue_make_request(BLK_DEFAULT_QUEUE(MAJOR_NR), lvm_make_request_fn); /* optional read root VGDA */ @@ -504,7 +500,6 @@ if (unregister_blkdev(MAJOR_NR, lvm_name) < 0) { printk(KERN_ERR "%s -- unregister_blkdev failed\n", lvm_name); } - blk_cleanup_queue(BLK_DEFAULT_QUEUE(MAJOR_NR)); gendisk_ptr = gendisk_ptr_prev = gendisk_head; while (gendisk_ptr != NULL) { @@ -1730,21 +1725,6 @@ return; } #endif - - -/* - * this one never should be called... - */ -static void lvm_dummy_device_request(request_queue_t * t) -{ - printk(KERN_EMERG - "%s -- oops, got lvm request for %02d:%02d [sector: %lu]\n", - lvm_name, - MAJOR(CURRENT->rq_dev), - MINOR(CURRENT->rq_dev), - CURRENT->sector); - return; -} /*