On Thu, 2008-01-03 at 10:30 +0100, Ingo Molnar wrote:
> * Trond Myklebust <[EMAIL PROTECTED]> wrote:
>
> > commit 53478daff2c8b494d2af1ede6611f166f81bc393
> > Author: Trond Myklebust <[EMAIL PROTECTED]>
> > Date: Wed Jan 2 13:28:57 2008 -0500
> >
> > NFS: Fix a possible Oops in fs/nfs/super.c
> >
> > Sigh... commit 4584f520e1f773082ef44ff4f8969a5d992b16ec (NFS: Fix NFS
> > mountpoint crossing...) had a slight flaw: server can be NULL if sget()
> > returned an existing superblock.
> >
> > Fix the fix by dereferencing s->s_fs_info.
> >
> > Also add in the same namespace Oops fix for NFSv4 in both the mountpoint
> > crossing case, and the referral case.
> >
> > Signed-off-by: Trond Myklebust <[EMAIL PROTECTED]>
>
> shouldnt this commit have included the full credit of the bugfix:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=9647
>
> ------------>
> Description From Adrian Bunk 2007-12-27 12:36
>
> The Coverity checker spotted that commit
> 4584f520e1f773082ef44ff4f8969a5d992b16ec introduced the following NULL
> dereference in 2.6.24-rc6:
Point taken, however I assume that a reference to the bugzilla report
should suffice. I've therefore updated the commit changelog to read as
follows:
NFS: Fix a possible Oops in fs/nfs/super.c
Sigh... commit 4584f520e1f773082ef44ff4f8969a5d992b16ec (NFS: Fix NFS
mountpoint crossing...) had a slight flaw: server can be NULL if sget()
returned an existing superblock.
Fix the fix by dereferencing s->s_fs_info.
Thanks to Coverity/Adrian Bunk and Frank Filz for spotting the bug.
(See http://bugzilla.kernel.org/show_bug.cgi?id=9647)
Also add in the same namespace Oops fix for NFSv4 in both the mountpoint
crossing case, and the referral case.
Signed-off-by: Trond Myklebust <[EMAIL PROTECTED]>
Cheers
Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
