On Wed, Feb 03, 2021 at 04:43:59PM +0200, Mihai Carabas wrote: > Add pvpanic pci device driver support.
What does that mean? Please provide more changelog text here. > > Signed-off-by: Mihai Carabas <[email protected]> > --- > drivers/misc/pvpanic/Kconfig | 16 ++++++++++- > drivers/misc/pvpanic/Makefile | 7 +++++ > drivers/misc/pvpanic/pvpanic-pci.c | 54 > ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 76 insertions(+), 1 deletion(-) > create mode 100644 drivers/misc/pvpanic/pvpanic-pci.c > > diff --git a/drivers/misc/pvpanic/Kconfig b/drivers/misc/pvpanic/Kconfig > index 12bb017..4a96e8d 100644 > --- a/drivers/misc/pvpanic/Kconfig > +++ b/drivers/misc/pvpanic/Kconfig > @@ -1,6 +1,11 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# pvpanic device > +# While nice, why add this now? > + > config PVPANIC > bool "pvpanic device support" > - depends on PVPANIC_MMIO > + depends on (PVPANIC_MMIO || PVPANIC_PCI) > help > This option enable generic code for pvpanic device driver logic. > > @@ -12,3 +17,12 @@ config PVPANIC_MMIO > This driver provides support for the pvpanic device. pvpanic is > a paravirtualized device provided by QEMU; it lets a virtual machine > (guest) communicate panic events to the host. > + > +config PVPANIC_PCI > + tristate "pvpanic pci device support" > + depends on PCI > + select PVPANIC > + help > + This driver provides support for the pvpanic device. pvpanic is > + a paravirtualized device provided by QEMU; it lets a virtual machine > + (guest) communicate panic events to the host. > diff --git a/drivers/misc/pvpanic/Makefile b/drivers/misc/pvpanic/Makefile > index d08379b..fe57d1f 100644 > --- a/drivers/misc/pvpanic/Makefile > +++ b/drivers/misc/pvpanic/Makefile > @@ -1,2 +1,9 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Makefile for pvpanic device. > +# Again, nice, but nothing to do with this change. Please only do "one thing" per patch. thanks, greg k-h
