On Sun, Jan 31, 2021 at 09:24:36AM -0800, Andy Lutomirski wrote:
> In general, page fault errors for WRUSS should be just like get_user(),
> etc. Fix three bugs in this area:
>
> We have a comment that says that, if we can't handle a page fault on a user
> address due to OOM, we will skip the OOM-kill-and-retry logic. The code
> checked kernel *privilege*, not kernel mode, so it missed WRUSS. This
> means that we would malfunction if we got OOM on a WRUSS fault -- this
> would be a kernel-mode, user-privilege fault, and we would invoke the OOM
> killer and retry.
Please convert all those commit messages to passive voice - the "we" is
ambiguous.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
