On 2/3/21 10:57 PM, Greg Kroah-Hartman wrote:
On Mon, Feb 01, 2021 at 09:56:57AM +0800, zhenwei pi wrote:
On 1/30/21 3:08 AM, Joe Perches wrote:
Add newline terminations to the sysfs_emit uses added by -next
commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
Signed-off-by: Joe Perches <[email protected]>
---
drivers/misc/pvpanic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index b1e4922a7fda..9f350e05ef68 100644
--- a/drivers/misc/pvpanic.c
+++ b/drivers/misc/pvpanic.c
@@ -25,13 +25,13 @@ static unsigned int events;
static ssize_t capability_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%x", capability);
+ return sysfs_emit(buf, "%x\n", capability);
}
static DEVICE_ATTR_RO(capability);
static ssize_t events_show(struct device *dev, struct device_attribute
*attr, char *buf)
{
- return sysfs_emit(buf, "%x", events);
+ return sysfs_emit(buf, "%x\n", events);
}
static ssize_t events_store(struct device *dev, struct device_attribute
*attr,
Hi, Greg is the maintainer of this driver.
No I am not:
$ ./scripts/get_maintainer.pl drivers/misc/pvpanic.c
Arnd Bergmann <[email protected]> (supporter:CHAR and MISC DRIVERS)
Greg Kroah-Hartman <[email protected]> (supporter:CHAR and MISC
DRIVERS)
[email protected] (open list)
As the developer of this driver, it would be great if you
could review the change and provide a "Signed-off-by" line that I can
use to accept this patch.
thanks,
greg k-h
Commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
is not merged into upstream currently, so this change should not affect
the up layer users. It looks good to me.
Signed-off-by: zhenwei pi <[email protected]>
--
zhenwei pi
