On Jan 4, 2008 9:34 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> * Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>
> > Before:
> > total: 25 errors, 13 warnings, 602 lines checked
> >
> > After:
> > total: 3 errors, 13 warnings, 602 lines checked
>
> thanks, applied. Would you be interested in fixing the other errors and
> warnings too? (Feel free to ask how to resolve certain types of
> warnings. I just took a quick look and all the current checkpatch.pl
> output on profile.c shows genuine style issues.)
Yes I am.
First of all I would like to be sure that my usage of checkpatch.pl is corretc,
what I do is the following:
[EMAIL PROTECTED]:~/linux-2.6/kernel$ ../scripts/checkpatch.pl
--file profile.c
and then I start fixing the errors (so far I didn't start looking at
the warnings).
What I still don't understand are the following options:
--no-tree => run without a kernel tree
--root => path to the kernel tree root
Should I specify the path to the kernel tree root? If so, why?
That said, the errors reported by checkpatch.pl are now:
[EMAIL PROTECTED]:~/linux-2.6/kernel$ ../scripts/checkpatch.pl
--terse --file profile.c |grep ERROR
profile.c:128: ERROR: "foo * bar" should be "foo *bar"
I just forgot to fix it, very trivial. Will do in a minute.
profile.c:460: ERROR: do not use assignment in if condition (+ if
(!(entry = create_proc_entry("XXXXXXXXXXXXX", 0600, root_irq_dir))))
profile.c:594: ERROR: do not use assignment in if condition (+ if
(!(entry = create_proc_entry("XXXXXXX", S_IWUSR | S_IRUGO, NULL))))
Here I need an hint ( or an example) about how to fix these two errors :-)
After that, I'll focus on the warnings.
Thanks Ingo!
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
