On Fri, Feb 05, 2021 at 08:31:22PM -0600, Josh Poimboeuf wrote: > On Fri, Feb 05, 2021 at 04:30:56PM +0100, Peter Zijlstra wrote: > > On Wed, Feb 03, 2021 at 03:04:23PM +0100, Peter Zijlstra wrote: > > > Fair enough I suppose. I'll slap a changelog and your SoB on it and I > > > suppose I'll got commit the whole lot. Then we can forget about it > > > again. > > > > FWIW, the whole thing looks like this.. > > > > --- > > Subject: static_call: Allow module use without exposing static_call_key > > From: Josh Poimboeuf <jpoim...@redhat.com> > > Date: Wed, 27 Jan 2021 17:18:37 -0600 > > > > From: Josh Poimboeuf <jpoim...@redhat.com> > > > > When exporting static_call_key; with EXPORT_STATIC_CALL*(), the module > > can use static_call_update() to change the function called. This is > > not desirable in general. > > Looks good to me, thanks for fixing that up. Never said I tested it ;-)
Yeah, and I'm the genius that 'tested' it with a MODULES=n build :-)