Hi,
On 2/7/21 4:50 AM, Colton Booth wrote:
> I can't test myself since I don't have the correct hardware, BUT this change
> seems to work for him. I'm thinking he has an early version of the X1E which
> may use slightly different trackpad revision.
Who is "him"? Do you have a bug-report link or some such ?
With which kernel version is this ? Could it be that the commit you are
reverting was
backported to a stable-series release while that stable series is missing the
rmi4
updates necessary to make things work on newer models ?
What are the symptoms / problems "him" is seeing when not reverting this?
On case it is not clear: NACK due to insufficient information why this is
necessary / missing description and root cause analysis of the actual problem.
Regards,
Hans
>
> Signed-off-by: Colton Booth <col...@boothsoftware.ca>
> ---
> drivers/input/mouse/synaptics.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index ffad142801b3..2d3f03921dbc 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -179,9 +179,7 @@ static const char * const smbus_pnp_ids[] = {
> "LEN0093", /* T480 */
> "LEN0096", /* X280 */
> "LEN0097", /* X280 -> ALPS trackpoint */
> - "LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */
> "LEN009b", /* T580 */
> - "LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */
> "LEN200f", /* T450s */
> "LEN2044", /* L470 */
> "LEN2054", /* E480 */
>
