> -----Original Message----- > From: Rafael J. Wysocki <[email protected]> > Sent: Monday, February 8, 2021 5:01 AM > To: Shawn Guo <[email protected]>; Ard Biesheuvel > <[email protected]>; Kaneda, Erik <[email protected]> > Cc: Linux ARM <[email protected]>; ACPI Devel Maling > List <[email protected]>; Linux Kernel Mailing List <linux- > [email protected]>; open list:ACPI COMPONENT ARCHITECTURE > (ACPICA) <[email protected]>; Wysocki, Rafael J > <[email protected]>; Len Brown <[email protected]>; Moore, > Robert <[email protected]> > Subject: Re: [PATCH] Revert "ACPICA: Interpreter: fix memory leak by using > existing buffer" > > On Sat, Feb 6, 2021 at 11:49 AM Shawn Guo <[email protected]> wrote: > > > > On Sat, Feb 06, 2021 at 09:49:37AM +0100, Ard Biesheuvel wrote: > > > This reverts commit 32cf1a12cad43358e47dac8014379c2f33dfbed4. > > >
Hi Bob, Ard and Rafael, > > > The 'exisitng buffer' in this case is the firmware provided table, and > > > we should not modify that in place. This fixes a crash on arm64 with > > > initrd table overrides, in which case the DSDT is not mapped with > > > read/write permissions. Since this code runs on basically every _HID and _CID invocation, I would have expected this kind of revert to come in for kernels that do not use initrd override... So it sounds like there is a difference between how pages are mapped for initrd table overrides and tables exposed through the XSDT for ARM.. I think it would be easier for us to make these fixes in the future if we could all come to a consensus on whether if we should assume that these pages are writable or not. Should we assume that all ACPI tables are non-writable and read only regardless of initrd override and architecture? > > > > > > Cc: Robert Moore <[email protected]> > > > Cc: Erik Kaneda <[email protected]> > > > Cc: "Rafael J. Wysocki" <[email protected]> > > > Cc: Len Brown <[email protected]> > > > Reported-by: Shawn Guo <[email protected]> > > > Signed-off-by: Ard Biesheuvel <[email protected]> > > > > Tested-by: Shawn Guo <[email protected]> > > Applied, thanks! > > Erik, the upstream will need to sync up with this revert. Ok sounds good. Erik
