On Saturday 05 January 2008 16:09:44 Ingo Molnar wrote: > * Miguel Botón <[EMAIL PROTECTED]> wrote: > > Before 'topology_32.h' and 'topology_64.h' were unified, topology > > defines in a X86_64 kernel were declared if CONFIG_SMP was enabled. > > Now, post unification, these same defines in a X86_64 kernel are only > > being declared if CONFIG_NUMA and CONFIG_SMP are enabled. > > > > This, for example, breaks 'perfmon_amd64.c' compilation. > > > > This patch defines ENABLE_TOPO_DEFINE if this is a X86_64 kernel and > > we have SMP support enabled. > > hm, do you have a .config that fails to build? > > Ingo
I had a .config (I deleted it) that fails to build *but* using the tree from http://git.kernel.org/?p=linux/kernel/git/eranian/linux-2.6.git;a=summary The problem was that CONFIG_NUMA wasn't defined so ENABLE_TOPO_DEFINE wasn't defined too and then we get an error about an implicit declaration of 'topology_physical_package_id'. -- Miguel Botón -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/