On Fri, Feb 12, 2021 at 03:44:52PM +0000, Min Li wrote: > > > > > > -set combomode > > > -get dpll's state > > > -get dpll's ffo > > > > > > This driver must work with Renesas MFD driver to access SMU through > > > I2C/SPI. > > > > > > Changes since v1: > > > -Provide more background for purpose of the change. > > > -Provide compat_ioctl support > > > -Fix ioctl cmd definition > > > > This "changes" list goes below the --- line. > > > > Sorry, is this a problem that you are requesting me to address? I am bit > confused...
Yes, please place that list of changes below the --- line in your patch. The documentation says to do this, right? > > And you seem to have ignored my review, especially about documenting the > > sysfs files here, please do that as I can not accept this patch as-is. > > > > If I come up with an rsmu.rst under Documentation/driver-api, is that > something you are looking for? No, all sysfs files need to be documented in Documentation/ABI/ thanks, greg k-h
