Hi Kyle, Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing] [also build test ERROR on v5.11-rc7 next-20210212] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Kyle-Tso/usb-typec-tcpm-Export-partner-Source-Capabilities/20210214-113553 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: i386-randconfig-m021-20210214 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/a80af7a2f4fa112b43e7b2b262729a8e1b28c132 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Kyle-Tso/usb-typec-tcpm-Export-partner-Source-Capabilities/20210214-113553 git checkout a80af7a2f4fa112b43e7b2b262729a8e1b28c132 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/usb/typec/tcpm/tcpm.c: In function 'tcpm_get_partner_src_caps': >> drivers/usb/typec/tcpm/tcpm.c:5762:11: error: implicit declaration of >> function 'tcpm_copy_pdos' [-Werror=implicit-function-declaration] 5762 | nr_pdo = tcpm_copy_pdos(*src_pdo, port->source_caps, | ^~~~~~~~~~~~~~ At top level: drivers/usb/typec/tcpm/tcpm.c:2106:39: warning: 'tcpm_altmode_ops' defined but not used [-Wunused-const-variable=] 2106 | static const struct typec_altmode_ops tcpm_altmode_ops = { | ^~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/tcpm_copy_pdos +5762 drivers/usb/typec/tcpm/tcpm.c 5741 5742 /* 5743 * Don't call this function in interrupt context. Caller needs to free the 5744 * memory by calling tcpm_put_partner_src_caps. 5745 */ 5746 int tcpm_get_partner_src_caps(struct tcpm_port *port, u32 **src_pdo) 5747 { 5748 unsigned int nr_pdo; 5749 5750 mutex_lock(&port->lock); 5751 if (port->nr_source_caps == 0) { 5752 mutex_unlock(&port->lock); 5753 return -ENODATA; 5754 } 5755 5756 *src_pdo = kcalloc(port->nr_source_caps, sizeof(u32), GFP_KERNEL); 5757 if (!src_pdo) { 5758 mutex_unlock(&port->lock); 5759 return -ENOMEM; 5760 } 5761 > 5762 nr_pdo = tcpm_copy_pdos(*src_pdo, port->source_caps, 5763 port->nr_source_caps); 5764 mutex_unlock(&port->lock); 5765 return nr_pdo; 5766 } 5767 EXPORT_SYMBOL_GPL(tcpm_get_partner_src_caps); 5768 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
